Does this wiring look right on the first picture? And for the second picture Does the lighting coil green go to green harness wire and yellow coil wire go to green/red harness wire?this is off a dt250a 1974

Ok i might be wrong but first pic the black wire underneath should be earthed & the top wire [red] should go to the condenser which also goes to the points. Then should have a wire from there [condenser] going to the plug coil or the loom to eventualy find its way there. I'm tired so might not be viewing the pic very well. Not sure about the lighting but would expect a yelow there somewhere if the loom is original. In the end your yellow should be highest output for your lights. If ya not running a 'regulator' & have no battery in the system, then run a regulator or yellow will blow ya bulbs. Green will be less output, used for daytime charging with battery. Regulator [single wire 6volt AC reg] will give you great lights from yellow & save them at the bright limit from blowing bulbs. Can't think anymore & ignore above if it's all sounds like rubbish lol.

Looks to me like you have a lighting coil from a newer model?

Yellow does not go to green... but later models had only one green.

Can't make out what the red is doing. Doesn't look right to me though.

On second look & expanding it up, is that black coming up onto the condenser?, so yes as Mark says--where's the red going. Is it a genuine ignition source coil as doesn't follow the shape of where it screws to the plate on the inner side. Not that it matters i guess but does need to be earthed. One wire to condenser & one to earth. Which way around i don't know, but 'will' matter.